Skip to content

E2E: Fix classic TIP test #8259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

E2E: Fix classic TIP test #8259

merged 1 commit into from
Aug 25, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Aug 25, 2025

What do these changes do?

the frontend behavior changed recently and the test was not accustomed to it.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Voyager milestone Aug 25, 2025
@sanderegg sanderegg self-assigned this Aug 25, 2025
@sanderegg sanderegg added the e2e Bugs found by or related to the end-2-end testing label Aug 25, 2025
YuryHrytsuk
YuryHrytsuk approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

matusdrobuliak66
matusdrobuliak66 approved these changes Aug 25, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.02%. Comparing base (2755211) to head (02be267).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8259      +/-   ##
==========================================
+ Coverage   88.01%   88.02%   +0.01%     
==========================================
  Files        1919     1919              
  Lines       74325    74325              
  Branches     1305     1305              
==========================================
+ Hits        65419    65427       +8     
+ Misses       8513     8505       -8     
  Partials      393      393
Flag Coverage Δ
integrationtests 63.95% <ø> (+0.03%) ⬆️
unittests 86.67% <ø> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.37% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.05% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 72.35% <ø> (ø)
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.81% <ø> (+0.22%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.97% <ø> (+0.06%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.10% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.24% <ø> (-0.06%) ⬇️
storage 86.36% <ø> (+0.08%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.08% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2755211...02be267. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

odeimaiz
odeimaiz approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 02be267.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI [int] director-v2 02 (3.11, ubuntu-24.04) Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View
integration-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

pcrespov
pcrespov approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@sanderegg sanderegg merged commit e873406 into ITISFoundation:master Aug 25, 2025
146 of 148 checks passed
@sanderegg sanderegg deleted the e2e/fix-tip-test branch August 25, 2025 19:43
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 2, 2025
Closed
61 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2025
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels

e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Milestone

Voyager

Development

Successfully merging this pull request may close these issues.

5 participants

@sanderegg @pcrespov @odeimaiz @YuryHrytsuk @matusdrobuliak66